GlendaChong / pe

0 stars 0 forks source link

Stall items names don't trim in-between spaces #9

Open GlendaChong opened 11 months ago

GlendaChong commented 11 months ago

Screenshot 2023-11-17 at 4.39.26 PM.png

Even though duplicates are not accepted, however, having Chicken Rice and "Chicken Rice" with many spaces in betweem, are both accepted as inputs, even though they should be regarded as duplicates.

This causes occasional inconvenience to users, as some users may type more than one spacings if they type fast.

soc-pe-bot commented 11 months ago

Team's Response

We will reject this as it is simply a typo on the user's part that causes the name of the item to become different than any that exists in the stall already, even if that difference is just 1 character.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that this feature flaw should be accepted, rather than rejected or NotInScope, as fixing this feature flaw is essential for the app to be reasonably useful.

This feature flaw suggestion ensures that the duplicate detection of the app is truly accurate. While the team now deems "Chicken Rice" (with one space) and "Chicken Rice" (with 2 spaces) as non-duplicates, these 2 food items are unlikely to mean 2 different items in the same stall, and hence potentially an input of a duplicate item. While the team argues that this is a typo on the user's end, which is true, the app could have given a warning in such near match cases so that the user can make the final decision.

Furthermore, according to the website:

If you app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected. Otherwise, it can be considered a type.FeatureFlaw.

Such limitations of the app for the duplicate detection feature is not made known to users, as shown in the UG screenshot below, which is why this is a valid FeatureFlaw, which will make the duplicate detection feature more complete than in v1.4. Screenshot 2023-11-22 at 2.34.03 AM.png

Also, to classify a feature flaw as NotInScope, the team has to satisfy these conditions according to the website:

In addition, the following (at least one) need to be satisfied:

  • The UG specifies it as not supported or coming in a future version.
  • The user cannot attempt to use the missing feature or when the user does so, the software fails gracefully, possibly with a suitable error message i.e., the software should not crash.

in this case, the UG did not specify anything about the flaw, as stated earlier. Also, the user can attempt to use the feature but will simply go past the duplicate detection. Hence, none of the 2 conditions are satisfied. Therefore, this valid feature flaw is not considered NotInScope, but a bug that has to be accepted and fixed.

Such a fix will also not require much effort, as it can be done by simply replacing the in-between spaces between words to just a single space (i.e. multiple spaces between words Chicken and Rice can be replaced into a single space, single space between words will remain as single space), before performing the equality check of the item_names.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]