GlennOngJunJie / pe

0 stars 0 forks source link

Add command dont allow for year 5 #6

Open GlennOngJunJie opened 1 year ago

GlennOngJunJie commented 1 year ago

Inputting year above 4, is not allowed but for business student many of them take loa, master degree students as well. Will be hard to use for 4k mods and above

image.png

nus-se-script commented 1 year ago

Team's Response

We might need to cater to these edge cases for future iterations. However, this would be a minor inconvenience for users of this nature as this type of students are much less common than the bulk of the student population in NUS, which are undergraduates with a 4 year course.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Year after 4 not allowed

Understand that this may be an edge case. However, this feature does not solve the stated problem of the intended user which is to aid in contact management for networking.

It is possible for students to go past the year of 4 although conventionally students graduate at year4. Hence, this input contraint placed by the software may be constriaining to the user and hinder their contact management instead of aiding.

A possible improvement would be to take in users matriculation year and month as well as expected graduation year and month. And calcualte the year from those inputs. This would greatly aid in the users contact management as the year of the contact would update yearly.

Screenshot 2023-04-14 at 2.43.55 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#2844] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the suggestion but as the year still functions for our contact management purposes, we did not implement it as suggested. It is a good suggestion nonetheless but it would require each person to know the matriculation year as well as which year it is currently. Hence, it is a possible improvement in further iterations but not in the scope for the tp.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] Same as the response i gave earlier
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]