Remove admin rest dependency

sigdestad commented 2 years ago

This might be a bug in XP 7.8-B, but it would be great if you took a look?

GlennRicaud commented 2 years ago

I installed and run Enonic XP 7.8.0-B1+Content Studio and I am getting 404 already there (cf. screenshot). There is a problem with the distro and in particular the /admin/rest API Reproduced after restart

I see the following logs at the end of the startup. Meaning that this happen after the applications have started:

2021-11-23 18:23:05,704 INFO o.jboss.resteasy.resteasy_jaxrs.i18n - RESTEASY002225: Deploying javax.ws.rs.core.Application: class com.enonic.xp.jaxrs.impl.JaxRsServlet$JaxRsApplication 2021-11-23 18:23:05,705 INFO o.jboss.resteasy.resteasy_jaxrs.i18n - RESTEASY002215: Adding singleton provider com.enonic.xp.jaxrs.impl.CommonFeature from Application class com.enonic.xp.jaxrs.impl.JaxRsServlet$JaxRsApplication 2021-11-23 18:23:05,706 INFO o.jboss.resteasy.resteasy_jaxrs.i18n - RESTEASY002220: Adding singleton resource com.enonic.xp.admin.impl.rest.resource.status.StatusResource from Application class com.enonic.xp.jaxrs.impl.JaxRsServlet$JaxRsApplication 2021-11-23 18:23:05,706 INFO o.jboss.resteasy.resteasy_jaxrs.i18n - RESTEASY002220: Adding singleton resource com.enonic.xp.admin.impl.rest.resource.auth.AuthResource from Application class com.enonic.xp.jaxrs.impl.JaxRsServlet$JaxRsApplication

GlennRicaud commented 2 years ago

GlennRicaud commented 2 years ago

Update: It seems a lot of endpoint have been moved out of the runtime: In 7.7: https://github.com/enonic/xp/tree/7.7/modules/admin/admin-impl/src/main/java/com/enonic/xp/admin/impl/rest/resource In 7.8.0.B1: https://github.com/enonic/xp/tree/v7.8.0-B1/modules/admin/admin-impl/src/main/java/com/enonic/xp/admin/impl/rest/resource

That is a breaking change for ContentStudio (and also DataToolbox, that is reusing 1 existing endpoint even though it should not)

GlennRicaud commented 2 years ago

Not sure what is the gain by having /admin/rest/tasks duplicated in each XP app.

I will reimplement it in DT and release a new version of DT this week

sigdestad commented 2 years ago

Yes, we have removed all undocumented API, and out them into respective apps. CS4 fixes content studio

GlennRicaud commented 2 years ago

Fixed. Will be released in DT v5.0.20

sigdestad commented 2 years ago

Killer, is it 7.7 compatible as well?

GlennRicaud commented 2 years ago

Yes. Compatible with >=7.3 (So they can already update today).

I already sent the following information to Persijn:

- 5.0.20 (Nov 26th 2021)
  - Adaptation: Remove admin rest API dependency (Required by Enonic XP 7.8)
  - Compatibility:7.3.0

GlennRicaud / data-toolbox-app

Remove admin rest dependency #63