GliaX / Otoscope

An open source otoscope ear inspection device that uses disposable specula. The goal is to bring production down to approximately USD$5 per unit
Other
85 stars 17 forks source link

add freecad versions of head_lock, name_plate, name_plate_locks #5

Closed mwganson closed 5 years ago

tareko commented 5 years ago

Thank you for this! This is wonderful. This addresses issue #4. I will review and @Frankie-E4Rdesigns will also review and hopefully integrate.

Note to self: include in "source" so it's a bit more agnostic.

Frankie-E4Rdesigns commented 5 years ago

The name_plate and name_plate_locks are perfect. Thanks!

For the head lock, the bottom "plate" part looks good, but the other "locking" piece is actually supposed to be skewed/tipped forward by 3 degrees, to properly line up with the grade on the top of the otoscope head. Would you be able to make this change?

mwganson commented 5 years ago

The funny part is it originally had the angle and I straightened because I thought it was a mistake.

tareko commented 5 years ago

Mark: @Frankie-E4Rdesigns has signed off on the changes. Could you please tell me two things:

  1. Name / affiliation to recognize you. I think we're going to add this to a contributors file.

  2. Could you email me with what you'd like to do re: payment (tarek@tarek.org or info@glia.org). We are trying to work out our budget for this conversion. It will probably be ~$3K-5K USD for the entire CAD component of this project, divided between contributors and FreeCAD. We'd like to either send you some amount of money to recognize your contribution or donate it to the FreeCAD project in your name, perhaps pointed at an issue or feature that you want addressed. For simplicity, payments wouldn't happen until we wrap up the CAD parts, but I'll reexamine that if things drag, so we should do it in the next month or so at this pace.

tarek : )

tareko commented 5 years ago

OK, here's what I've done in commit 2f79349317f5521421d636e58ebad2960c30df20:

  1. I moved the files into source_files instead of starting a new Freecad_source_files
  2. I moved the otf file (font) into assets
  3. I edited the name_plate.FCStd so that the reference to the font is relative, not absolute (it was pointing to your downloads directory or something, @mwganson.

I think this should pretty much close this pull request.