GliderGeek / PySoar

Gliding competition analysis
http://www.pysoar.com
GNU General Public License v3.0
17 stars 7 forks source link

analysis breaks: task definition #98

Closed GliderGeek closed 7 years ago

GliderGeek commented 7 years ago

http://www.soaringspot.com/en_gb/pribina-cup-2017-nitra-2017/results/open/task-2-on-2017-04-16/daily (14/04 - 22/04)

files are downloaded correctly, but task definition seems off: LSEEYOU OZ=-1,Style=2SpeedStyle=0,R1=5000m,A1=180,Line=1

questions:

Answers:

GliderGeek commented 7 years ago

This is found in the file:

LSEEYOU OZ=-1,Style=2SpeedStyle=0,R1=5000m,A1=180,Line=1
LSEEYOU OZ=0,Style=1SpeedStyle=3,R1=500m,A1=180,Reduce=1
LSEEYOU OZ=1,Style=1SpeedStyle=3,R1=500m,A1=180,Reduce=1
LSEEYOU OZ=2,Style=5SpeedStyle=3,R1=500m,A1=180,Reduce=1
LSEEYOU OZ=3,Style=5SpeedStyle=2,R1=3000m,A1=180,Reduce=1
LSEEYOU TSK,NoStart=12:38:00

It is unclear which Style should be taken for the sector orientation. From taskpoint.py:

if style == 0:
    return "fixed"
elif style == 1:
    return "symmetrical"
elif style == 2:
    return "next"
elif style == 3:
    return "previous"
elif style == 4:
    return "start"

taking the first style (2,1,1,5,5) would be: next, symmetrical, symmetrical, ?, ? taking the second style (0, 3, 3, 3, 2) would be: fixed, previous, previous, previous, next

for the first i don't know what style 5 is for the second it is strange that the finish is oriented to next.

GliderGeek commented 7 years ago

it should be noted that for the al sectors are circles for the example file, and hence the orientation is technically not necessary. this corner-case could be implemented to make it works for those cases in which the waypoints are all circles

GliderGeek commented 7 years ago

for the lasham case and the third one, it seems that the first style produces reasonable result: 2,1,1,1,3: next, symm, symm, symm, previous.

GliderGeek commented 7 years ago

Maybe the error comes from a bug in Seeyou or SoaringSpot within a limit time frame. This might be the case since the most recent comps do not seem to suffer from this.

Comp name Start-date Format problem
Lasham Easter Training 13/4 - 23/4 y
Pribina Cup 2017 14/4 - 22/4 y
Campionato Italiano Classe Libera 2017 16/4 - 23/4 n
Чемпионат России в клубном классе 2017 28/4 - 12/5 y
13. Jarní pohár Jeseníků 2017 29/4 - 7/5 y
Championnat de France 2017 29/4 - 6/5 n
Alföldi – LX Navigation Cup 2017 29/4 - 7/5 n
Wetzlarer Woche 2017 30/4 - 6/5 n
fatraglide17 6/5 - 13/5 n
2017 m. Vilniaus taurė 6/5 - 22/5 n
Königsdorfer Wettbewerb 2017 6/5 - 13/5
Gelderse 1 daagse 2017 6/5 - 7/5
15in Polish Gliding Championship in Class Club A 12/5 - 21/5
REGIONAL GLIDING COMPETITION IN CLUB CLASS A 12/5 - 21/5
Campionato Italiano 18 metri 12/5 - 22/5
Sjællandsmesterskaberne 2017 - Part 1 12/5 - 14/5
Sallandse Overlanddag 2017 13/5 - 13/5
Brasov Cup 2017 13/5 - 20/5
KSS and AZ GCC Prievidza 2017 13/5 - 21/5
RM Birrfeld 2017 13/5 - 21/5
2017 m. Antano Ruko taurė 13/5 - 28/5
Championnats romands alpes 2017 18/5 - 21/5
EIVV 21/535 15/5 - 26/5
Internationaler HAHNWEIDE Segelflugwettbewerb 2017 19/5 - 27/5 y
GliderGeek commented 7 years ago

script for fixing task:

import os

files = os.listdir(os.curdir)
for filename in files:

    if filename == 'fix_task.py':
        continue

    with open(filename) as f:
        lines = f.read().replace("SpeedStyle=0", "").replace("SpeedStyle=2", "").replace("SpeedStyle=3", "")
    with open(filename, "w") as f1:
        f1.write(lines)

the replace functionality can be incorporated in the code, or in some pre-processing step of the files