search

Glimesh / broadcast-box

A broadcast, in a box.
MIT License
688 stars 57 forks source link

Forward RTCP packets from WHIP connections to WHEP sessions #116

Open esonderegger opened 4 months ago

esonderegger commented 4 months ago

This PR adds forwarding of RTCP packets from the RTP receivers for each track of WHIP connections, sending them to the peer connections of the stream's WHEP sessions.

I'm brand new to the broadcast-box code base and I have two questions:

  1. Is it bad to be adding a reference to the peerConnection to the whepSession struct like this? Could this lead to memory leaks?
  2. Should we be forwarding all RTCP packets or just certain types? For example, should we be forwarding sender reports but ignoring source descriptions?