search

Glimesh / glimesh.tv

Glimesh is a next generation live streaming platform built by the community, for the community.
https://glimesh.tv
Other
471 stars 79 forks source link

Fixed video container height for ultralarge viewports #822

Closed cactysman closed 2 years ago

cactysman commented 2 years ago

This PR is based on #811, but adds simple CSS to ensure the video container height doesn't exceed the viewport height in whichever arbitrary viewport the user might be using.

Before: image

After: image

clone1018 commented 2 years ago

Hey @cactysman thanks for submitting this, can you explain the difference between this and #811 for me? Should your changes also contain mja's changes?

cactysman commented 2 years ago

Hey @cactysman thanks for submitting this, can you explain the difference between this and #811 for me? Should your changes also contain mja's changes?

Hey there, yes, that's why his commit is included here.

The difference is that #811 adds some support for 21:9 viewports, but the video player still grows larger than the page height (as demonstrated in the screenshots). So the CSS keeps it in place.

clone1018 commented 2 years ago

Looks good, thanks!