search

Glimesh / glimesh.tv

Glimesh is a next generation live streaming platform built by the community, for the community.
https://glimesh.tv
Other
471 stars 79 forks source link

Giving users the power to turn off receipt of Gift Subs #862

Closed Ribenaberri closed 2 years ago

Ribenaberri commented 2 years ago

Small QoL Update after a conversation in discord recently.

Giving users the power to turn off receiving gift subscriptions. Some users prefer not to bad able to receive them, this could be a host of reasons as to why a user may not want to receive gift subs. With this in mind, and inkeeping with the Glimesh ethos of giving everyone a choice over how their accounts can function, I have now added this capacity.

Located under user preferences is a toggle, this is on by default but users may turn it off if they wish.

unknown1

unknown

If this is toggled off any user trying to give that person a gift sub will be notified by an error message before proceeding to checkout, which will prevent the person gifting from being charged.

Further discussion will be available in a Building Glimesh thread.

Thanks all!

clone1018 commented 2 years ago

Thanks for the PR! I'd actually rather have this implemented more similar to how we have the other support modal options. They are stored in the channel table, under names like: show_subscribe_button, show_streamloots_button, etc. Can you pivot this PR to use that table instead and update the UI to be in the Channel Addons tab? https://glimesh.tv/users/settings/addons

Here's how most of it is wired up: https://github.com/Glimesh/glimesh.tv/search?q=show_donate_button

Ribenaberri commented 2 years ago

Can you pivot this PR to use that table instead and update the UI to be in the Channel Addons tab? https://glimesh.tv/users/settings/addons

That would only work if a user has a channel though for it to be visible, this isn't on a channel level. This is so all individuals can have the power to turn off the capacity to be gifted a subscription by other users. Being in the channel addons tab would not be a good fit for this as its for the individual person, streamer, or viewer, to be able to use.

If you want to go down that sort of route in terms of keeping things uniform, we would likely need a user equivalent option of the support modal.

We can of course also add this in so a streamer an turn off all gift subs for their channel, but that is different to what this particular PR is about.

clone1018 commented 2 years ago

FWIW my comment above is useless as I didn't understand this was to turn off gift sub receiving... :D