Closed MemoryLeakDeath closed 1 year ago
If you can, rebase this against dev
(the main branch) and the tests should magically pass.
Rebasing complete, tests have passed. Thanks again!
Resolved merge conflicts.
rebased with dev
Do we know when this will be pushed out to release? If you don't know it's fine, just It's getting kinda aggravating having to set it to not show viewer count every time I open up the web page, and that it defaults to showing the number.
Do we know when this will be pushed out to release? If you don't know it's fine, just It's getting kinda aggravating having to set it to not show viewer count every time I open up the web page, and that it defaults to showing the number.
Sorry, I don't know when.
Do we know when this will be pushed out to release? If you don't know it's fine, just It's getting kinda aggravating having to set it to not show viewer count every time I open up the web page, and that it defaults to showing the number.
Since this adds the ability for streamers to disable their viewer count for all users who view their channel, it's likely this PR will take awhile to merge it as an idea we want Glimesh to have.
Allowing streamers to hide the viewer count is not currently aligned with our goals. Remembering view count hiding for users as a personal preference is a good idea. We can re-evaluate this when the beta is nearer to launch.
Absolutely fine by me! I was moreso meaning the basic ability of anyone to hide that count for theirself, not hide it for other people and not give them a choice.
Viewer Count Toggle
Based on a suggestion on Building Glimesh. Streamers would like the ability to hide the viewer count on their channel page. I've increased the scope of this suggestion to also allow viewers to choose whether the viewer count (when visible) is expanded or minimized.
New Settings
Channel Settings
The channel owner can choose whether they want the viewer count to appear on their channel. By default, the viewer count is on.
Preferences page
Viewers can choose if they want the viewer count on all channels to display expanded (default) or be minimized. Regardless of the setting users can still click the viewer count button to toggle it from expanded to minimized or vice versa. Viewers cannot make the viewer count visible on channels that have hidden the count.
Affects of the various settings
Default settings
Database Changes