search

Glimesh / janus-ftl-plugin

A plugin for the Janus WebRTC gateway to enable relaying of audio/video streams utilizing Mixer's FTL (Faster-Than-Light) protocol.
https://hayden.fyi/posts/2020-08-03-Faster-Than-Light-protocol-engineering-notes.html
GNU Affero General Public License v3.0
44 stars 11 forks source link

Docker builds fail silently due to lack of libsystemd-dev #103

Closed luludotdev closed 3 years ago

luludotdev commented 3 years ago

As noted in the title, the Dockerfile was not modified in #99 to add libsystemd-dev, presumably due to Docker images not benefiting from using systemd. However because of this, the build silently fails as Meson notes the missing dependency and does not build the project. After reading over #99 I believe this to be an error due to misconfiguration of Meson, as it seems that compile time support was meant to be optional.

danstiner commented 3 years ago

Hmm systemd support was indeed meant to be optional, I'll look at how it broke

danstiner commented 3 years ago

@lolPants could you share the output you see? I'm having trouble reproducing

luludotdev commented 3 years ago

This is the full Docker build log, the relevant Janus FTL build step starts at line 2627. The rest of the logfile is installing dependencies and such, but is included for completeness sake. This build was performed against c8666a63e043cbea91734092a2d50ac6400727ff (latest master at time of writing).

Both this and the follow-up below were built using Docker Desktop 3.2.1 using Docker Engine 20.10.5 and the bundled version of BuildKit. The command used was docker build --no-cache --progress plain -t janus .

https://pastebin.com/EPb40Zga

luludotdev commented 3 years ago

As a follow-up, simply adding libsystem-dev to the Dockerfile results in the build completing as expected. https://pastebin.com/wcrUxFbS (line 2647)

danstiner commented 3 years ago

Thanks, PR out with the fix. (I'm having issues with Docker on WSL2 so it was hard for me to repro, sharing the output helped)