Closed danstiner closed 3 years ago
I'm a bit torn how far to go with adding tests to this PR, I think to really make the logic testable it should be pulled into more specialized buffer/nack tracking classes.
Maybe before merging I should add at least one happy path test of relaying packets, and then as we refactor this we can add more tests.
Meant to be a minimal set of changes to bring back the NACK. Further refactoring can come later.
Tested on the homelab without/with feature enabled. Enabling this makes a substantial improvement in all the simulated packet loss scenarios I've done.
Fixes #95