Glimesh / janus-ftl-plugin

A plugin for the Janus WebRTC gateway to enable relaying of audio/video streams utilizing Mixer's FTL (Faster-Than-Light) protocol.
https://hayden.fyi/posts/2020-08-03-Faster-Than-Light-protocol-engineering-notes.html
GNU Affero General Public License v3.0
44 stars 11 forks source link

Potential deadlock introduced by #72 #74

Closed luludotdev closed 3 years ago

luludotdev commented 3 years ago

After testing the new REST service using the latest master, which introduces new code from #72 (which wasn't around while writing the REST service), when a stream fails to authenticate the server seems to lock up. No new connections can be made, no attempt to contact the REST API is made, and when trying to exit with a CTRL+C the process hangs. (You can still spam CTRL+C to exit, but Janus warns about freeing resources cleanly)

This behaviour was not noted during development of #73 so I can only attribute it to #72

haydenmc commented 3 years ago

Will take a look, thanks!