This change updates us to v0.8.4 of cpp-httplib, which includes a decent number of fixes to bugs that I suspect may be causing some of our HTTPS request failures we're seeing in production.
As a result of some of the changes in the httplib update, a few changes were made to the ServiceConnection implementations to avoid copying of httplib::Client and httplib::Result instances (they are now backed by unique_ptr).
Additional logging detail was also added in the Glimesh HTTP request failure case so we can determine root cause if this doesn't resolve the failures.
Verified by testing against local glimesh.tv instance.
This change updates us to
v0.8.4of cpp-httplib, which includes a decent number of fixes to bugs that I suspect may be causing some of our HTTPS request failures we're seeing in production.As a result of some of the changes in the httplib update, a few changes were made to the ServiceConnection implementations to avoid copying of
httplib::Clientandhttplib::Resultinstances (they are now backed byunique_ptr).Additional logging detail was also added in the Glimesh HTTP request failure case so we can determine root cause if this doesn't resolve the failures.
Verified by testing against local glimesh.tv instance.