search

Glimesh / waveguide

A polyglot WebRTC media server.
GNU Affero General Public License v3.0
37 stars 8 forks source link

Fix cancellation of thumbnailer loop on input stream close #21

Closed nassah221 closed 1 year ago

nassah221 commented 1 year ago

This PR addresses a bug introduced with #20 for issue #16 where the Peersnap(thumbnailer) would not exit it's RTP read loop when input stream was stopped or closed. The issue seemed to appear when using OBS to stream on either RTMP or FTL protocols.

The fix required deriving a contextWithCancel from the parent context in control and invoking the cancel func in control.StopStream

clone1018 commented 1 year ago

Woo!