search

Glimpse / Glimpse.Prototype

Glimpse v2 prototype
MIT License
185 stars 44 forks source link

Use Environment.MachineName #135

Closed Jetski5822 closed 7 years ago

Jetski5822 commented 7 years ago

Instead of using Environment.GetEnvironmentVariable("COMPUTERNAME") - as this is hacky... use Environment.MachineName.

Implemented here: https://github.com/dotnet/corefx/pull/5428

Also reordered usings.

avanderhoorn commented 7 years ago

Thanks for the update! I remember doing this and it was a hack i introduced post the .net and asp.net "merger". Looks good to me, only quick question, I'm assuming this works crossplat?

Jetski5822 commented 7 years ago

Based on the feedback on that thread I posted, yes its cross plat :)

avanderhoorn commented 7 years ago

Dam, don't know how I missed that link. Thanks!