Glimpse / Glimpse.Prototype

Glimpse v2 prototype
MIT License
184 stars 44 forks source link

Appending html to PostContent rather than set #92

Closed damienpontifex closed 8 years ago

damienpontifex commented 8 years ago

Resolves #91 by appending html to post content rather than overwriting with setcontent

avanderhoorn commented 8 years ago

@damienpontifex great pickup! In your test, I'm assuming that things work correct in both cases (where you do and don't have additional content)? As a note, we are looking at switching things so that we inject Glimpse scripts without razor dependency (see #77).

damienpontifex commented 8 years ago

From my testing (adding local glimpse into src of my global.json file and testing on my project), Glimpse is still injected into PostContent for both cases: when it is the only one there and also when I'm injecting further additional content.

77 looks like it might be a little way off, so I'd love to see this integrated into the current implementation so it doesn't effect users currently utilising the Razor/TagHelper approach.

nikmd23 commented 8 years ago

This looks like a no brainer to me. Thanks for finding and fixing the bug @damienpontifex!

avanderhoorn commented 8 years ago

Thanks!