search

Glimpse / Home

Project Glimpse: Node Edition - Spend less time debugging and more time developing.
http://node.getglimpse.com
Other
252 stars 9 forks source link

Glimpse breaks AWS-SDK S3 calls #113

Closed chriskinsman closed 7 years ago

chriskinsman commented 7 years ago

var AWS = require('aws-sdk'); var s3 = new AWS.S3({accessKeyId: config.AWSACCESSKEYID, secretAccessKey: config.AWSSECRETACCESSKEY, region: config.AWSREGION});

s3.getObject({
        Bucket:bucket,
        Key: prefix + '/' + key
    }, function(err, data) {

--> Without glimpse installed data.body is a UInt8Array with a length that matches content. With glimpse installed the array is always empty. i.e. retrieving an object from S3 fails

});

mike-kaufman commented 7 years ago

Thanks For reporting this @chriskinsman. We'll look into it...

philliphoff commented 7 years ago

Thanks for submitting the issue, @chriskinsman! We've been able to reproduce the problem and have a pretty good idea of what's happening; it looks like our interception of the response data for Glimpse reporting purposes is interfering with aws-sdk's management of the response data. We'll work on a fix and let you know when it's available in an upcoming release.

avanderhoorn commented 7 years ago

It looks like we have a solution and are currently doing some testing to make sure we have gotten all the edge cases we can see. Hopefully this will get in the upcoming release. We will let you know how testing goes! Thanks again.

mike-kaufman commented 7 years ago

Fix for this is availabe on NPM now with glimpse version 0.21.5.