Closed chetsangnil closed 8 years ago
1.2. Add error/warning icon in front of status number.
This is a great idea, but we should be careful of how its presented.
Many tools show a success icon for 2XX responses, warning for 3XX responses, and error for 4XX and 5XX responses. Given this fairly common convention, it might be confusing for users, or they might not realize that our status icon has more/different meaning than in other tools.
That said, I agree with the spirit of this suggestion, we should just find a better way to present it.
Just chatted with Nik, here's a new placement for error/warning icons.
@nikmd23 : We talked about putting error/warning icons next to the total time, I tired, but it will be very clutter in the future once we have "browser icon (chrome, edge, ..etc.)" in place. So I thought it will work better to add them according to the mock below.
Regarding On Going
currently its impossible to get into this state as we only show the request once its finished. Thats because we only know the response type once the request has finished and for the time being we we only want to show a subset of all requests.
In the future we have had discussions about knowing whether requests are in progress and what do we do with them before adding them to the list (as a future search filter might exclude them)... some thought needs to go into this and is not likely going to happen in this release.
For now I log to the console any requests that we get and don't show. If we thought that we are going to have a lot of "partial" requests, we could add logic which logs out requests that haven't been completed in 30+ seconds or something. But given timing around things, I would put this toward the top of the nice to have list for this release.
Closing this off now. Other issues now capture the intent of what this was for.
When I have a lot of requests in the left panel, I found myself spending a lot of time looking through each one to see which one I should be investigating. This is not very helpful.
After discussing with Phil, I would like to purpose a simple way to get around this problem:
1.2. Add error/warning icon in front of status number. This will base on status code semantic (for example, 404 = error) as well as what's being generated in logs tab. For example, GET 200 is not an error but there is an error message in the logs tab for the associated request, therefore warning icon appear next to the GET 200 status code. We can limit this behavior to only warning and error.