[Shell] Number within the table should be right align

Glimpse / Home

Project Glimpse: Node Edition - Spend less time debugging and more time developing.

http://node.getglimpse.com

Other

252 stars 9 forks source link

[Shell] Number within the table should be right align #56

Open chetsangnil opened 8 years ago

chetsangnil commented 8 years ago

Please right align columns with numbers for all tables, including:

[ ] Request / Middleware / Duration
[ ] Data / Duration
[ ] Web Services / Duration

nikmd23 commented 8 years ago

@chetsangnil, I've explicitly listed the places where I see this issue, but I was unsure if you wanted this behavior on Ordinal columns as well.

If so, or if there are any other missing columns, please update the original comment and add their location to the list.

avanderhoorn commented 8 years ago

@chetsangnil As we roll offsets through the app they will all be right aligned. Current that just leaves ordinals. Given that ordinals have the client/server indicator, do you still want them right aligned?

chetsangnil commented 8 years ago

Please do leave Ordinal number left align! (this left alignment for Ordinal number becomes very critical especially in grouping scenario) Other number column can be right align.