search

Glimpse / Home

Project Glimpse: Node Edition - Spend less time debugging and more time developing.
http://node.getglimpse.com
Other
252 stars 9 forks source link

Client does not load in Safari #6

Closed philliphoff closed 8 years ago

philliphoff commented 8 years ago

Navigating to /glimpse/client/?baseUrl=/glimpse/client appears to do nothing in Safari. You will be prompted (once) to select the metadata URI, but using the default does not result in a page being shown. The console window shows the following error:

[Warning] Invalid CSS property declaration at: ; (main.css, line 920)
[Error] TypeError: window.fetch is not a function. (In 'window.fetch(metadataUri)', 'window.fetch' is undefined)
    (anonymous function)
    (anonymous function)
    (anonymous function)
    onEnter
    (anonymous function)
    (anonymous function)
    (anonymous function)
    next
    loopAsync
    runTransitionHooks
    runEnterHooks
    (anonymous function)
    runTransitionHooks
    runChangeHooks
    finishMatch
    (anonymous function)
    next
    loopAsync
    matchRoutes
    match
    (anonymous function)
    listen
    listen
    Router_componentWillMount
    performInitialMount
    mountComponent
    mountComponent
    performInitialMount
    mountComponent
    mountComponent
    performInitialMount
    mountComponent
    mountComponent
    performInitialMount
    mountComponent
    mountComponent
    mountComponentIntoNode
    perform
    batchedMountComponentIntoNode
    perform
    batchedUpdates
    batchedUpdates
    _renderNewRootComponent
    _renderSubtreeIntoContainer
    render
    render
    eval code
    eval
    (anonymous function) (bundle.js:59)
    __webpack_require__ (bundle.js:20)
    eval code
    eval
    (anonymous function) (bundle.js:50)
    __webpack_require__ (bundle.js:20)
    (anonymous function) (bundle.js:40)
    global code (bundle.js:41)
philliphoff commented 8 years ago

It appears that the new fetch() API isn't yet supported by all major browsers, in particular, by Safari and IE 11 (only the latest Edge 14 supports it).

See: http://caniuse.com/#feat=fetch

chetsangnil commented 8 years ago

Should this be something to worry about then?

philliphoff commented 8 years ago

Should this be something to worry about then?

I'd say it not working in IE11 and Safari is problematic, as that's potentially a big chunk of users. They both can use Chrome as a workaround, but better we just fix it so it works across most of the big browsers.

chetsangnil commented 8 years ago

sounds like a plan! ;)