search

Glimpse / Home

Project Glimpse: Node Edition - Spend less time debugging and more time developing.
http://node.getglimpse.com
Other
252 stars 9 forks source link

[Feature Request] Enable "just my code" for timeline view #87

Open lostintangent opened 7 years ago

lostintangent commented 7 years ago

In the spirit of continuing to reduce noise, it would be cool if the new timeline tab allowed enabling a "just my code" filter, which removed all of the logical events that don't actually represent user code (e.g. the standard boilerplate middleware ala cookie parsing), and therefore, aren't likely to be a common source of performance issues.

This was one of the most frequent requesteds we heard on the timeline tool in the IE F12 tools (we obviously showed waaaay more noise than Glimpse does), and we found that users were extremely interested in removing as many distractions as possible from their investigations. It's possible that there are ways to abuse the standard Express middleware (e.g. the JSON parser being expensive because you're POSTing a larger than needed JSON body), but I wonder whether half of the data in the following image could be hidden without impacting the identification of real perf problems in many scenarios. Not sure, so I'm just thinking out loud.

image

I'm sure this is already on the roadmap, so I'm just logging this to voice my vote for the enhancement :) This is also a companion to #33, with the goal of enabling JMC across the board.

nikmd23 commented 7 years ago

Question for you @lostintangent:

I understand your desire to remove events from this screen "to reduce noise". In the examples you gave around "standard boilerplate middleware", do you see those being removed because they are part of some sort of "I'm not worried about this" list, or because they "take less than X amount of time" so I'm not worried about them?

lostintangent commented 7 years ago

@nikmd23 Mostly the "I'm not worried about this" list. That said, I could be wrong that you shouldn't worry about them. I was just generally thinking out loud, with the goal of making the timeline as laser focused on what the user is mostly likely to care about as possible (without permanently removing/hiding potentially meaningful data).