search

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype
MIT License
9 stars 3 forks source link

Adds middleware execution to Request tab #140

Closed philliphoff closed 8 years ago

philliphoff commented 8 years ago

Adds a table displaying the execution of middleware for a given request to the Request tab. The table shows nested middleware (e.g. router pipelines) as well as which piece of middleware set which outgoing header.

screen shot 2016-06-23 at 3 26 35 pm
philliphoff commented 8 years ago

Associated with #125, #126.

chetsangnil commented 8 years ago

Can we add abit more indentation for the nested items? For example, in ordinal 10, we can add enough indentation so that '<' line up with 't' from "router" above it.

avanderhoorn commented 8 years ago

Looks good. I made a few comments around various items, but the only thing blocking was a nit on some quote usage.

philliphoff commented 8 years ago

Can we add abit more indentation for the nested items? For example, in ordinal 10, we can add enough indentation so that '<' line up with 't' from "router" above it.

I've added a bit more indentation; it won't be exact though as we're using proportional (i.e. non-mono-spaced) fonts which will affect the apparent indentation based on the naming of the two middleware.