Add display for request/response headers fixes #16

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype

MIT License

9 stars 3 forks source link

Add display for request/response headers fixes #16 #25

Closed avanderhoorn closed 8 years ago

avanderhoorn commented 8 years ago

Initial cut of adding the request/response headers to the execution screen.

Now awaiting feedback on what the design is - @nikmd23

avanderhoorn commented 8 years ago

Thinking out loud....

I'm wondering if we either hide the headers within a expandable section and show a summary like what we do in v1. -or- Riffing on the expander idea we just show the header keys and show the value when the user opens it -or- We could have a hybrid of what we have at the moment and an expander where the white list of headers that we want to always show and the rest are in the expander.

nikmd23 commented 8 years ago

I propose we move the headers to a "Request" tab. The layout you have now is good, it just doesn't have much to do with "execution".

There will be more things added to the request tab as we go, but it's not particularly interesting ATM. Thoughts?

avanderhoorn commented 8 years ago

I'm open to that... any ideas on what type of data we would see in a future Request tab besides headers? Thinking out loud, would we put the resources that this response triggered to load, etc?

nikmd23 commented 8 years ago

Yes, that's a good example.

Also I'm thinking things like:

Compression ratios
Protocol used
Request bodies
Cookies
CSP Violations
Data from HttpLint, WhatDoesMySiteCost and/or RedBot
Etc

Way down the line, I could even see some simple "edit and replay request" functionality on this page.

avanderhoorn commented 8 years ago

Great!

avanderhoorn commented 8 years ago

This means that I will close this PR and open up a new one. Do you have any thoughts on what the design could/should look like to support this vision?