search

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype
MIT License
9 stars 3 forks source link

Testing #4

Open ForbesLindesay opened 9 years ago

ForbesLindesay commented 9 years ago

@avanderhoorn mentioned that it would be useful to have some tests for Glimpse. I think it would be useful to discuss what exactly we want to test, and how we want to test it.

Which parts of the system would be most useful to test? What should we start testing first? Do we want to do full cross-browser integration testing, or do we want to start with simpler unit-testing?

avanderhoorn commented 9 years ago

Lets start off with prototyping what we want to do with the unit tests first. Specifically looking at the repository and store layers. Once we get a prototype up for how the "unit test" tests are looking, we can have a look at what is involved in something that is more end-to-end.

In terms of specific technology, I don't think I'm too attached to anything in particular but this was the list I had put together when originally looking at testing:

Do you have any thoughts around this?

ForbesLindesay commented 9 years ago

I've started setting up jest (which probably belongs in the "Unit Testing" category, as it's an entire test runner ala Qunit, Jasmine and Mocha, not just a mocking library).

Although I thin there's a lot to like about it, it doesn't seem to work properly on Windows out of the box. Personally I'm happy enough to do all Glimpse client dev on a mac, but I think that would limit contribution too much. We can include this patch to get it working properly on Windows.

avanderhoorn commented 9 years ago

I'm thinking we move forward with Jest. My thinking is that medium to longer term the windows issues will be sorted out and the benifits in the mean time are greater than someone having to put the work arounds in place. What you think?

On Tuesday, December 2, 2014, Forbes Lindesay notifications@github.com wrote:

I've started setting up jest (which probably belongs in the "Unit Testing" category, as it's an entire test runner ala Qunit, Jasmine and Mocha, not just a mocking library).

Although I thin there's a lot to like about it, it doesn't seem to work properly on Windows out of the box. Personally I'm happy enough to do all Glimpse client dev on a mac, but I think that would limit contribution too much. We can include this patch https://github.com/facebook/jest/pull/111 to get it working properly on Windows.

— Reply to this email directly or view it on GitHub https://github.com/avanderhoorn/Glimpse.Client.Prototype/issues/4#issuecomment-65227117 .