search

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype
MIT License
9 stars 3 forks source link

UX for logging levels and offsets #65

Closed philliphoff closed 8 years ago

philliphoff commented 8 years ago

Displays error/warning icons to trace message rows and displays the logging message offsets.

The icons are provided by FontAwsome, by way of the React library react-fa.

chetsangnil commented 8 years ago

Sorry for the confusion guys, the unit "ms" should be at the value level!! I must have missed it in the mock!!

mike-kaufman commented 8 years ago

lgtm

chetsangnil commented 8 years ago

Like so!

glimpse v_8
chetsangnil commented 8 years ago

and the reason why I chose to show "ms" at the value level is because 1.) Phil was right on the spot about improve readability and understanding 2.) numbers within the column will generally be shorter than its title. If we add "ms" next to the title of the column, we would run into a lot of empty space within the column itself.

But yes! please put back in the unit. It's very important!

chetsangnil commented 8 years ago

@avanderhoorn : if you look at the mock for Web services tab, you will see that "ms" is shown inside the column without a space--- (ex. 123ms). To keep it consistent with the logging page, please update for it to show with a space--- (ex. 123 ms). Thank you!

chetsangnil commented 8 years ago

About font, font awesome is great and I think we can definitely leverage the use of that. However, @avanderhoorn is right that we are still going to need our own set of icon as well because font awesome will not have all the assets we need to show in the UI.

philliphoff commented 8 years ago

Abandoning this PR in favor of a more recent attempt.