Adds filtering of trace/log messages

GlimpseArchive / Glimpse.Client.Prototype

Glimpse v2 Client prototype

MIT License

9 stars 3 forks source link

Adds filtering of trace/log messages #83

Closed philliphoff closed 8 years ago

philliphoff commented 8 years ago

Allows the user to filter trace/log messages by level.

The "component model" (i.e. "view model") concept has been split into separate components, the model itself and optional state which can reside with the React component (UI) and persist across models. (This enables the filter selection to be "sticky" as the user switches between requests, making comparisons of logs easier.)

The styling of the tab has also been updated to match the latest redlines.

philliphoff commented 8 years ago

Related to #78.

mike-kaufman commented 8 years ago

Would be interesting to see how responsive the UI feels with a large number of log messages. E.g.,500?

philliphoff commented 8 years ago

Would be interesting to see how responsive the UI feels with a large number of log messages. E.g.,500?

I experimented with a request that generated 1500 messages; the UI feels pretty responsive at that level. I think if we were to adopt Redux, we could probably do better as it makes it pretty easy to ignore re-renders for components not affected by the state change.

mike-kaufman commented 8 years ago

Great about the responsiveness. This LGTM. What needs to happen to merge this in?

philliphoff commented 8 years ago

Just waiting for @avanderhoorn to also sign-off.

avanderhoorn commented 8 years ago

After that one minor style change/revert, :shipit: