GlitchEnzo / NuGetForUnity

A NuGet Package Manager for Unity
MIT License
3.09k stars 310 forks source link

Src unpack is not supported #193

Open ryzngard opened 5 years ago

ryzngard commented 5 years ago

Description

When making a package with "IncludeSource" set to true, the package contains a folder src\ProjectName. That folder does not get unpacked when NuGetForUnity installs the package, but is contained within the nupkg that gets copied.

jwittner commented 5 years ago

Looks like it's getting explicitly deleted here: https://github.com/GlitchEnzo/NuGetForUnity/blob/0098e01aca2304fc050990a3fca30ce1d666f751/Assets/NuGet/Editor/NugetHelper.cs#L300

A quick search didn't pop up anything about IncludeSource, would love to understand it more. If it contains the source code that built the contents of the lib folder then I fear we'd have a conflict if it was preserved - Unity would try to compile the .cs files and loading the DLL causing duplicates. Maybe we can move it to some external folder?

ryzngard commented 5 years ago

Yea, I was trying to make a source only pack which would mean that the conflict wouldn't be a problem. I wonder if this can be solved by just asking the user what they should unpack if both exist?