Glitchfiend / BiomesOPlenty

Minecraft mod that adds over 50 new biomes to the game.
https://www.curseforge.com/minecraft/mc-mods/biomes-o-plenty
Other
823 stars 257 forks source link

No Ocean Monuments or Mansions? #1011

Closed Galindorf closed 7 years ago

Galindorf commented 7 years ago

BEFORE SUBMITTING!

For feature requests, please delete this template and create your own. If this is an issue, ensure the following before reporting:

I have generated several worlds and noticed that there are no ocean monuments to be found! I have also not run across any Desert Temples, or Roofed Forest Mansions. Is this a thing, or have I just been radically unlucky?

Steps to reproduce:

  1. Generate a New World
  2. Fly Around a Lot of Ocean Biomes
  3. Notice the Lack of Ocean Monuments

Additional Information:


Affected Versions (Exact numbers, do not use "latest"):

Syndaryl commented 7 years ago

Use the locate command to find structures if you're in doubt.

Forstride commented 7 years ago

Woodland Mansions do not generate yet, but I can confirm that ocean monuments do generate.

Syndaryl commented 7 years ago

I've seen a couple of Woodland Mansions... There's one in my current world in fact.

Galindorf commented 7 years ago

Yeah, using the "locate" command I was able to find all of the items in question, but I don't know if it's because of where Minecraft thought they "should" be (according to the algorithm) or if they would have generated in the chunks as I walked. On Vanilla minecraft (as of 1.10) you couldn't seem to swing a dead cat without hitting an ocean monument. I guess we've just been really unlucky!

Syndaryl commented 7 years ago

You can tell /locate is working correctly and not "conjuring" the features into being just because you ran it, because they get put in sensible biomes. It doesn't generate ocean monuments in Badlands, or Woodland Mansions in Mesas. BOPs world gen algorithm is so different from vanilla, there's just no alignment of appropriate biomes (Except by staggeringly good fortune).

Syndaryl commented 7 years ago

You'll see a difference in Vanilla minecraft vs BOP simply due to distribution of biomes. More of the "ocean" isn't Deep Ocean - you get Coral Reefs and so forth, and those can't spawn Ocean Monuments. Further, depending on the world type you might just get less wide stretches of ocean! Anything that depends on generating only in Vanilla biomes will be less common, because now those Vanilla biomes are competing with the very large list of BOP biomes. That's just how it works.

It is, as they say, "Working as intended".

Adding BOP-equivalent versions of the Desert Temple in e.g. Outback or Steppe biomes, or Jungle Temple in e.g. Rainforest biome would be a "solution", but that's not a bug-fix, that's a big-honking-feature.

Forstride commented 7 years ago

"Adding BOP-equivalent versions of the Desert Temple in e.g. Outback or Steppe biomes, or Jungle Temple in e.g. Rainforest biome would be a "solution", but that's not a bug-fix, that's a big-honking-feature."

We don't really need to add "equivalents," we'd just allow those vanilla structures to generate in our similar biomes. Adubbz was working on setting that up for the woodland mansions at one point, although IDK if he ever even finished it.

And of course, desert temples, jungle temples, igloos, etc. need to generate in our biomes as well.

Forstride commented 7 years ago

Woodland Mansions and other vanilla structures now generate in various BOP biomes.