Glitchfiend / BiomesOPlenty

Minecraft mod that adds over 50 new biomes to the game.
https://www.curseforge.com/minecraft/mc-mods/biomes-o-plenty
Other
800 stars 250 forks source link

Add option to render all Anomaly blocks as static variants #2217

Open Nova-Katt opened 2 months ago

Nova-Katt commented 2 months ago

What's the issue you encountered?

I've been playing BoP for quite some time and hadn't really explored the end yet due to not finding a stronghold. Yesterday I did, and headed in.

Eventually we came upon the corrupted end biome that was littered with "glitched" holes and liquids, including the weird anomaly block.

From a distance everything was fine, and it looked like a 3x3 cube of animated static. Then I got closer, and it suddenly turned into a 5x5 cube of, whatever to call it. The anomaly block flips through ALL the possible blocks in the entire game more or less, and does so very rapidly. The problem is that the more of those blocks you have, the more demanding it gets when it's constantly at hyper speed changed it's appearance to another block, any block, and it's quick.

Even if I turn my shaders OFF to save on FPS, I still experience very noteable lag when near just 1 of those 4x4-6x6 cubed of anomalies. Add in 2-5 more of those cubes nearby and... well.... Without shaders I was running 150 fps, with shades I ran at 50 fps. But when I was close to the anomalies I dropped to 10-30 fps for the NONshaded one, and with shaders on, yeah it was more or less 2-5 fps.

The anomalies are waaay to laggy unless you run a superbeefy computer, and not everyone does that. Having 1 or 2 of the anomaly blocks is one thing, but spawning several clumps of 4x4 to 7x7 does take a massive hit to fps to the point of almost unplayable, or unplayable if there are multiple clumps nearby.

My suggestion is to either have them spawn in just 1x1 block over those holes... Or just keep them as they are at far distance, meaning, that animated noise-static, rather than flipping through all the -other- blocks at hyper speed.

(And if you do change them, then please do not -only- make that change for 1.20.6. Many of us stay at 1.20.4 until 1.21 is released) <3

How can the issue be reproduced?

Just start placing down anomaly-blocks. The more you place down the more it will lag until it becomes unbearable. And in the End biome, they are everywhere.

Logs

No response

Mod Version

BiomesOPlenty-fabric-1.20.4-19.0.0.89

Additional information

No response

Forstride commented 2 months ago

Flipping through the blocks isn't what causes framerate drops (Which is just entirely visual, not actually changing the block), it's just them rendering at all, because they require tile entities to work as they do. Also if they were only 1x1, the intended effect would be lost completely.

We tried as much as we could to increase performance with them, but as you said, not everyone is going to have the same hardware. At best, we could probably add an option to force all anomaly blocks to render as the static ones, but beyond that, I'm not sacrificing the design of the biome for people trying to play heavily modded Minecraft with shaders on a 10 year old PC or whatever.

Nova-Katt commented 2 months ago

Got it! Thank you for your fast response as always! :D And yeah I would love an option toggle for keeping them as the noise tv-static. :D Sounds likea fair deal so you can keep them the way they are now, while also giving a performance option for those who need it. :)