Glitchfiend / TerraBlender

TerraBlender is a library mod for adding biomes in a simple and compatible manner with Minecraft's new biome/terrain system.
https://www.curseforge.com/minecraft/mc-mods/terrablender
GNU Lesser General Public License v3.0
95 stars 30 forks source link

1.19.2 Trees fail to generate in most modded biomes after updating from .130 to .136 #106

Closed LoftyLoftyLoftyLoftyLofty closed 1 year ago

LoftyLoftyLoftyLoftyLofty commented 1 year ago

What's the issue you encountered?

Multiple biomes fail to generate with trees.

How can the issue be reproduced?

Generate modded biomes using .130 instead of .136. Affected biomes from multiple mods, try with Biomes O' Plenty or Terralith (Ominous woods is a good example)

Logs

No response

Mod Version

1.19.2-2.0.1.136

Additional information

No response

Adubbz commented 1 year ago

I can't reproduce this on 1.19.3 or 1.19.2 image image

Aleon4201 commented 1 year ago

In my case, no trees from Oh the Biomes You'll Go are spawned in the Nether on the new world. I saw issues of it, I found that there's a problem with Terrablender.

M0thership-Th3ta commented 1 year ago

https://github.com/AOCAWOL/BYG/issues/1150 The BYQ Issue Tracker has had a few people reporting the same issue. (Me included)

RechercheRaptor commented 1 year ago

I've been having this same issue and it's really been bugging me, at first I thought it was an OTBYG thing (and made a bug report over on its bug tracker) but it's definitely Terrablender.

The issue is exclusive to modded biome fauna and other features (like crystal clusters) in the Nether and End only. The Overworld biomes seem totally unaffected.

Terrablender beta 1.19.2-2.0.1.130 and Terrablender release 1.19.2-2.0.1.136 don't generate any of the BYG flora (or crystal clusters such as in the Subzero Hypogeal) in the Nether or End.

The earlier versions Terrablender beta 1.19.2-2.0.1.129 and Terrablender release 1.19.2-2.0.1.128 DO properly generate BYG flora. I haven't tested any earlier versions than that so I can't speak for those, but the most recent beta and release have some kind of weird error going on.

M0thership-Th3ta commented 1 year ago

It was every biome for me, at least in the overworld. I never tested the nether or end for me but considering other reports it was likely much the same thing.

My only explanation I can think of is that if you are using other mods that add biomes or biome changes to these dimensions, Terrablender messes up somewhere and it results in this. I've heard reports that changing NBT data in a worlds level file can fix it, but I wasn't properly explained how to do it. (and shouldn't be how the mod works anyway.)

1.18.2 works just fine, it's solely an issue with 1.19

huh

RechercheRaptor commented 1 year ago

It happened to me even when I had only Oh The Biomes You'll Go and Terrablender in a profile I made specifically to test it, and only in the Nether and End. It's very strange.

xyxt1c commented 1 year ago

I have the same issue using promenade. Doesnt generate any foliage in the blush sakura grove. Using Terrablender for Nyctophobia. Without Terrablender / Nyctophobia its fine.

MC 1.20.1 TerraBlender-fabric-1.20.1-3.0.0.165.jar

DarthShader commented 1 year ago

Can confirm this is still an issue on TerraBlender 2.2.0.168 with a fresh install of the following: Minecraft 1.19.4 Forge 45.1.0 OTBYG 4.0.0.2 CorgiLib 3.0.0.0 GeckoLib 4.2

xyxt1c commented 1 year ago

I have the same issue using promenade. Doesnt generate any foliage in the blush sakura grove. Using Terrablender for Nyctophobia. Without Terrablender / Nyctophobia its fine.

MC 1.20.1 TerraBlender-fabric-1.20.1-3.0.0.165.jar

I have to add: It only happens sometimes. Even with heavily modded terrain and feature generation it's most of the times fine. but sometimes biome features don't generate for modded content. If I generate a new world with the same seed, maybe 1/20 times.

mcd256 commented 1 year ago

Sorry to bring this post back from the dead but I'm still having this problem on 1.19.4. I've spent hours trying to find a fix for it but I'll probably just have to go back to an older version.

Adubbz commented 1 year ago

This issue should now be addressed in Minecraft 1.19.4 and 1.20.2. Note that the fix will only apply to newly generated worlds when using the latest mod version.