Glitchfiend / TerraBlender

TerraBlender is a library mod for adding biomes in a simple and compatible manner with Minecraft's new biome/terrain system.
https://www.curseforge.com/minecraft/mc-mods/terrablender
GNU Lesser General Public License v3.0
95 stars 30 forks source link

Biome Replacer can't fully replace vanilla biomes if TerraBlender-dependent mods are present #188

Open WerDei opened 1 week ago

WerDei commented 1 week ago

What's the issue you encountered?

Hi! I'm a developer of Biome Replacer. I'm not versed enough in Minecraft's worldgen code nor TerraBlender's, so I'm looking for some help.

Upon creation of a WorldStem, BR replaces biomes according to the rules in its config. This, in theory, should work as if biomes were removed using a worldgen datapack.

However, when a TerraBlender-dependent mod is installed (I tested with Nature's Spirit and Biomes o' Plenty), suddenly replacements can fail to apply in random areas.

Here's an example of what a vanilla world would look like: image Here's one where dark forest is replaced with cherry grove using BR: image And here is the same area after installing Nature's Spirit. You can see that only a part of the dark forest was replaced: image (Screenshots are taken with seed 9101978112017418412 at coords 898 128 1002)

Let me know if this is fixable from my side!

How can the issue be reproduced?

  1. Install Biome Replacer and add a simple rule to its config file, like minecraft:dark_forest > minecraft:cherry_grove
  2. Generate a world and run /locate biome minecraft:dark_forest. The biome won't be found, as expected
  3. Install TerraBlender and repeat step 2 using the same seed. You will notice that this time the game halts before showing the error, indicating that dark forest is present in BiomeSource's "possibleBiomes".
  4. Install Nature's Spitit or Biomes o' Plenty and repeat step 2 again. You will likely locate a dark forest.

Logs

No response

Mod Version

4.1.0.5

Additional information

Tested on Fabric 1.21.1 Mentioned mod's versions: