search

GloDroid / glodroid_manifest

Android port that aims to bring both user- and developer-friendly experience in using AOSP with a set of single-board computers (SBC), phones and other devices.
472 stars 66 forks source link

[Training task] Pinephone: Use Force Feedback interface instead of LED for Vibrator HAL #139

Closed rsglobal closed 3 years ago

rsglobal commented 3 years ago

This is one more step aligning with linux userspace.

From the very beginning of pinephone support, existing vibrator HAL was designed to work only with LED kernel driver, therefore additional DTS fragment was created.

Since we now migrated to AIDL Vibrator HAL we can adapt mainline Vibrator interface and remove DTS overlay section [1] and additional kernel config option [2].

[1] - https://github.com/GloDroid/glodroid_device/blob/00b1d1fd3a521fe04cec1ba56e6b017a4dc2b8f9/pinephone/android.dts#L5 [2] - https://github.com/GloDroid/glodroid_device/blob/00b1d1fd3a521fe04cec1ba56e6b017a4dc2b8f9/pinephone/kernel.config#L9

rsglobal commented 3 years ago

This task is work in progress state: https://github.com/GloDroid/glodroid_device/pull/25

rsglobal commented 3 years ago

PR merged.