search

GloDroid / glodroid_manifest

Android port that aims to bring both user- and developer-friendly experience in using AOSP with a set of single-board computers (SBC), phones and other devices.
472 stars 66 forks source link

Dockerfile improvement #184

Closed artemkostin closed 2 years ago

artemkostin commented 2 years ago

Please review suggested improvements and merge them as needed.

rsglobal commented 2 years ago

Please fix small typo: Minimaze Dockerfile layers -> Minimize Dockerfile layers

rsglobal commented 2 years ago

Just some feedback on Makefile.

In case no docker installed it doesn't gracefully exit and try run shell command starting from the first argument.
After installing docker , docker require some magic to work without sudo. It would be nice to add some readme on docker usage.

rsglobal commented 2 years ago

Also looks like make stop does not remove the container. make stop && make run causes error, while make clean && make run works.

rsglobal commented 2 years ago

@artemkostin ^^^^^