search

GloDroidCommunity / raspberry-pi

Android 14 for the Raspberry PI 4 series based on the GloDroid project
Apache License 2.0
28 stars 5 forks source link

Switch to audio hal from raspberry-vanilla #17

Closed mikegapinski closed 1 year ago

mikegapinski commented 1 year ago

I also don't expect this to be merged as is - it needs to be discussed.

On top of fixing HDMI audio it also adds support for external modules like HiFiBerry

rsglobal commented 1 year ago

Looks good. Is it possible to use alsa mainline repos + add a few Android-related patches on top?

mikegapinski commented 1 year ago

@rsglobal mainline alsa? I think so... The forks from raspberry-vanilla don't have much changes besides adding blueprints for AOSP build system.

I'll give it a shot and let you know

mikegapinski commented 1 year ago

@rsglobal switched to mainline alsa-lib and alsa-utils with patches.

It unfolded without issues, I'll have a build to flash in 45m

rsglobal commented 1 year ago

@mikegapinski ,

I spent 20min to align this PR with my "feel of beauty": https://github.com/rsglobal/raspberry-pi/tree/audio-hal-pr-small-rework

Not tested.

mikegapinski commented 1 year ago

@mikegapinski ,

I spent 20min to align this PR with my "feel of beauty": https://github.com/rsglobal/raspberry-pi/tree/audio-hal-pr-small-rework

Not tested.

I just tested my branch, I'll quickly build your rework and import it into this PR if it does not break anything.

mikegapinski commented 1 year ago

The PR works fine but it'll stay here as a draft until it gets polished. Switching to HDMI audio requires changing the ro.hardware.audio.primary property and this should be either not required or automated. Doing HDMI audio in tinyalsa is also a valid solution.

mikegapinski commented 1 year ago

Closing this, I did not end up shipping this HAL