search

Global-Chem / global-chem

A Knowledge Graph of Common Chemical Names to their Molecular Definition
https://globalchemistry.org/
Mozilla Public License 2.0
156 stars 21 forks source link

Replace the package name rdkit-pypi with rdkit. #309

Closed akuroiwa closed 5 months ago

akuroiwa commented 6 months ago

When building the global-chem-extensions package on Python 3.12, you need to replace the package name rdkit-pypi with rdkit.

akuroiwa commented 5 months ago

Dear global-chem-extensions maintainers,

I hope this message finds you well. I am following up regarding the pull request I submitted some time ago to change the dependency from rdkit-pypi to rdkit (PR #309).

The new package rdkit supports Python versions 3.8 through 3.12, whereas rdkit-pypi only supports Python versions 3.7 through 3.11.

I understand that reviewing and merging contributions can take time amidst other priorities. However, I would greatly appreciate if you could please take a look at this PR when you have a chance. The change is a simple one but would help align the project with the latest RDKit package naming conventions.

Please let me know if you need any additional information or have any other concerns regarding this PR. I'm happy to address them. Thank you in advance for your time and consideration.

Best regards, Akihiro Kuroiwa

Sulstice commented 5 months ago

Done! Thanks!