Global-Health-Engineering / template-quarto-revealjs-theme

0 stars 0 forks source link

Image-left/right class #1

Open sebastian-loos opened 1 year ago

sebastian-loos commented 1 year ago

Hey @larnsce

As far as I understand it the classes where adjusted to the desktop of Emil Hvidtfeldt and I'm supposing that one can adjust it to fit your own desktop by changing these parameters. Right now the picture wouldn't fill out the left/right borders of the screen..

In this part the variables slide-width and slide-height are calculated. I don't understand if the these variables are default variables and we are just redefining theme or if we are creating the variables from scratch. I've tried to define my own variables the same way (with a different name) and tried to include the new variable into the class at different spots. It partly worked but at one point I it would always thow everything off. Since I don't know what the values for the variables slide-* I don't understand the calculation that is done and cannot figure out a good adjustement. Nevertheless, it would be necessary to adjust it for every desktop type or is that wrong?

However, I went on and tried a different method without using any css-class and using the background-* attributes within the qmd-file... It works, but when you resize the browser the background image those not adjust in the same way as it does using the .image-* classes. It's not a big deal since you normaly dont have to resize the browser while presenting...

Since I haven't managed to adjust the parameters right, I personally prefer the "background" way. But I understand that it imposes more things that people would have to adjust by themselves, whereas the .image-* classes are straight forward for the users.

What is your opinion?

I tried to find some kind of source code that defines slide-* but haven't found it. If you have a clue please let me know, maybe we can define a calculation that fits for all desktop sizes and the problem would be solved:)

Thanks for your help!

Links: Letterbox-theme (source): Repo, Template,Custom Sass-file,

larnsce commented 1 year ago

Thanks for your great work on this, @sebastian-loos. I will have to look at the implementation of it and then go from there.