search

GlobalArrays / ga

Partitioned Global Address Space (PGAS) library for distributed arrays
http://hpc.pnl.gov/globalarrays/
Other
97 stars 38 forks source link

fix for missing definition of ga_deallocate #240

Closed edoapra closed 2 years ago

edoapra commented 2 years ago

See issues
https://github.com/nwchemgit/nwchem/issues/489
https://github.com/GlobalArrays/ga/issues/238
https://github.com/GlobalArrays/ga/issues/239

yurivict commented 2 years ago

Can a new release be made that includes this patch? 5.8.1 is broken.

edoapra commented 2 years ago

The fixed 5.8.1 tarball has been available since January 19th 2022 as https://github.com/GlobalArrays/ga/releases/download/v5.8.1/ga-5.8.1.tar.gz

yurivict commented 2 years ago

So there is a discrepancy then between the GitHub release and the external tarball release.

I tried the GH tag 5.8.1 and it has the problem.

edoapra commented 2 years ago

What files are you referring to?

The .tar.gz and .zip files were automatically generated before the bug was fixed.

Why would you want to use those files that have not gone through the same level of testing as the manually uploaded tarball? It seems an insane choice to me.

yurivict commented 2 years ago

I mean some distros may use github tags by default and they would use different source. Tags are supposed to be in sync in GH and in tarballs.

edoapra commented 2 years ago

Live fast, die young