secure_snprintf.patch download 404

[nick-wilson]

Hi,

When running the autogen.sh script the travis/install-autotools.sh script fails due to file not found when downloading https://raw.githubusercontent.com/macports/macports-ports/master/devel/m4/files/secure_snprintf.patch

[nick-wilson]

File was removed as issue was fixed upstream so patch probably does not need to be applied any more.

$ git log -p -- devel/m4/files/secure_snprintf.patch
commit 9e1c6767f2205b5016d33ade42a03405d324ed6e
Author: Lawrence Velázquez <larryv@macports.org>
Date:   Fri May 28 18:39:03 2021 -0400

    m4: Update to 1.4.19

    https://lists.gnu.org/archive/html/m4-announce/2021-05/msg00002.html

    Also remove patch for problem that was handled by upstream gnulib.

    https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=c41f233
    https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=7df04f9
    https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=b954346

To keep using patch you can use the URL for a tag containing the file:

$ git diff

diff --git a/travis/install-autotools.sh b/travis/install-autotools.sh
index b1c5160..90f89fc 100755
--- a/travis/install-autotools.sh
+++ b/travis/install-autotools.sh
@@ -109,7 +109,7 @@ else
     if [ -f secure_snprintf.patch ] ; then
         echo secure_snprintf.patch already exists! Using existing copy.
     else
-        ${download} secure_snprintf.patch https://raw.githubusercontent.com/macports/macports-ports/master/devel/m4/files/secure_snprintf.patch
+        ${download} secure_snprintf.patch https://raw.githubusercontent.com/macports/macports-ports/v2.7.0-archive/devel/m4/files/secure_snprintf.patch
     fi
     if patch -p0 -N < secure_snprintf.patch ; then
         echo patch applied

[edoapra]

@nick-wilson thanks for this report. This patch has been in the develop branch for a while. https://github.com/GlobalArrays/ga/commit/2d950ef898878ba53b45adb83508024498d29e27

I am not quite sure when it is going to be propagated to the master branch ... @ajaypanyala @bjpalmer any thoughts?

[bjpalmer]

I've been significantly sidetracked on my goal of putting out a release. I will try and get backed to it shortly, which should propagate everything in develop out to the main branch.

[nick-wilson]

OK. Thanks for the update. I'll close this issue.