search

GlobalArrays / ga

Partitioned Global Address Space (PGAS) library for distributed arrays
http://hpc.pnl.gov/globalarrays/
Other
96 stars 38 forks source link

Fix issue 279 #280

Closed jeffhammond closed 1 year ago

jeffhammond commented 1 year ago

Fixes #279 by giving Fortran subroutine declarations in C the void return type.

edoapra commented 1 year ago

@jeffhammond Did you start from a fresh develop branch?

jeffhammond commented 1 year ago

It is one commit now. It was originally a merge against master, which was a disaster.

edoapra commented 1 year ago

Something is not quite right yet. The issue of the FORTRAN definition of ga_deallocate() seems back.
I need to check if vanilla develop has the same issue again.

jeffhammond commented 1 year ago

If GitHub is accurate, my PR is unrelated to that.

edoapra commented 1 year ago

If GitHub is accurate, my PR is unrelated to that.

Yes, I agree. I just found out that the latest develop runs are using cache for some steps, while the github actions for your pull did not. Let me try to reproduce the problem after deleting the Github actions cache.