search

GlobalArrays / ga

Partitioned Global Address Space (PGAS) library for distributed arrays
http://hpc.pnl.gov/globalarrays/
Other
99 stars 38 forks source link

Make device utility function decls visible to HIP #298

Closed dmcdougall closed 1 year ago

dmcdougall commented 1 year ago

Newer ROCm compilers appear to have stricter ISO C99 compliance checks, and implicit function declarations are now compiler errors.

This change makes the declarations visible to the HIP backend.

dmcdougall commented 1 year ago

Well, it's C code, so I suppose it's not really the "ROCm compiler", but the C compiler invoked by the Cray cc compiler wrapper in newer versions of Cray PE.

jeffhammond commented 1 year ago

C99 compliance is always a good thing. I wish we were doing more of this.

dmcdougall commented 1 year ago

I see there are test failures, but I can't see why this change would have caused those.

ajaypanyala commented 1 year ago

@dmcdougall You can ignore the CI for now. There are breaking changes with the introduction of the GPU code. A regular build of GA does not work for this branch.