search

GlobalDataverseCommunityConsortium / dataverse-language-packs

Repository for language files associated with Dataverse
17 stars 44 forks source link

rename role.editor to role.contributor #108

Closed tcoupin closed 4 months ago

tcoupin commented 1 year ago

https://github.com/IQSS/dataverse/issues/7129

qqmyers commented 4 months ago

@tcoupin - trying to help clean up these old PRs. For this and your related #107 - it looks like the change in Dataverse was for 5.14, so does it make sense to update the 5.10 and 5.11 translations or should the changes go into a new 5.14 (or later) version?

tcoupin commented 4 months ago

I add my colleague @plecor who replace me on dataverse's subject at French IRD

plecor commented 4 months ago

Hi, The key was changed in 5.14 but the issue it fixes was itself introduced in 4.20 by https://github.com/IQSS/dataverse/pull/6662

The 4.20 PR renamed the role alias 'editor' to 'contributor', meaning the bundle resolutions is looking for role.contributor.name instead of role.editor.name, see https://github.com/IQSS/dataverse/blob/a57ce53c7c683d05959683de66c03199e465c2ad/src/main/java/edu/harvard/iq/dataverse/authorization/DataverseRole.java#L133

So the key role.contributor.name only exists in Dataverse since 5.14 through https://github.com/IQSS/dataverse/pull/9012, but is expected in the translation files since 4.20.

This PR is on 5.10 and not 4.20 because this is the one we are working with internally.