GlobalDataverseCommunityConsortium / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
13 stars 39 forks source link

File uploaded on undefined #4

Closed pdurbin closed 5 years ago

pdurbin commented 5 years ago

I'm getting "File uploaded on undefined" and I'm not sure why. Here's a screenshot:

Screen Shot 2019-04-02 at 1 16 55 PM

qqmyers commented 5 years ago

@pdurbin - hmm, the 'root' cause is because there is no creationDate listed for the file in the response to http://phoenix.dataverse.org/api/datasets/167/versions/1.0 - I'm not sure why that should be though.

qqmyers commented 5 years ago

@pdurbin - if you're seeing this all the time, perhaps I added creationDate to the metadata and that isn't in a PR yet, but I don't see that it should be inconsistent between datasets/files on one instance...

qqmyers commented 5 years ago

That's it - I added a line in JSONPrinter 4 months ago but I don't think it made it to a PR - I'll create an issue/PR for it.

qqmyers commented 5 years ago

Addressed with https://github.com/IQSS/dataverse/pull/5714... - also added an if statement to not show the date if it isn't sent and to note the limitation in the readme that (presumably) v4.12 is required to see the creationDate...

pdurbin commented 5 years ago

also added an if statement to not show the date if it isn't sent

I just tested 6309951 and this fix works fine. Closing. Thanks!

Heads up that Dataverse 4.12 is already out so maybe your fix will be in 4.13? Stay tuned. :smile: