search

GlobalDataverseCommunityConsortium / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
13 stars 38 forks source link

Internationalization should use the Dataverse localeCode #42

Closed qqmyers closed 4 years ago

qqmyers commented 4 years ago

Tools can be sent the locale, so we shouldn't need to have a separate translate button in the previewers - the previewers will use the locale configured by the user in Dataverse.

qqmyers commented 4 years ago

Just left some notes in #18 which is the only place I can use the 'at' sign to reach juancorr.

Summarizing: Updated to use the localeCode from Dataverse, moved the previewer-specific translation code to the previewer's specific *.js file, merged changes from master, did a little cleanup.

To test, I deployed the repo locally to a Dataverse instance (see #18 for details) and registered a previewer at that local URL.