search

GlobalDataverseCommunityConsortium / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
13 stars 38 forks source link

HTML lang and formatting #47

Closed kaitlinnewson closed 4 years ago

kaitlinnewson commented 4 years ago

This PR sets the HTML lang attribute based on the locale, and also cleans up some formatting/indentation in the HTML and CSS files.

qqmyers commented 4 years ago

@kaitlinnewson - thanks! Can you make a PR against the dev branch (which I've just restored after accidentally having it get deleted with the last merge :-)) instead? Since people use these live via github.io, I/we're trying to give some warning before any update and/or to let people test from the dev branch prior to updating master.

kaitlinnewson commented 4 years ago

@qqmyers Done!

qqmyers commented 4 years ago

@kaitlinnewson - if you want this deployed asap (which would be fine), let me know and I can announce the update and give people a few days notice. If not, or when you do, let me know - I might wait a while for additional changes.

kaitlinnewson commented 4 years ago

No rush - I'm hoping to submit some accessibility improvements soon too FYI!