search

GlobalDataverseCommunityConsortium / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
13 stars 38 forks source link

Resource URLs are hard-coded #51

Closed kaitlinnewson closed 3 years ago

kaitlinnewson commented 3 years ago

When preparing to change our local URL for the previewers application, we noticed that the resource URLs are hardcoded in the files, e.g.:

<script type="text/javascript" src="/dataverse-previewers/previewers/js/xss.js"></script>

To fix this in our install, we changed URLs to be relative instead, e.g.:

<script type="text/javascript" src="js/xss.js"></script>

I'm happy to make a PR to change this so others can use flexible URLs for their own apps, but wanted to make sure there weren't any issues with this change before doing so.

qqmyers commented 3 years ago

I don't see any reason to keep them as is and some (e.g. scripts in lib/*) are already relative, so +1 for a PR (to the dev branch). Thanks!