Update handsontable version and fix scroll display

GlobalDataverseCommunityConsortium / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse

MIT License

13 stars 38 forks source link

Update handsontable version and fix scroll display #53

Closed kaitlinnewson closed 3 years ago

kaitlinnewson commented 3 years ago

The scrolling on spreadsheets isn't currently working in develop. This should fix that, and also updates the handsontable package being used to the latest version which has more display options.

qqmyers commented 3 years ago

@kaitlinnewson - I see that HandsOnTable is no longer open source. It seems to be free for academic research but its less clear to me that government use is OK and I'm not sure we can redistribute it. Will your changes work with v 6.2.2 which is still open source? If not, perhaps we should have some discussion about how to proceed.

kaitlinnewson commented 3 years ago

Unfortunately the responsive height options were added in v. 7, so this won't work in 6.2.2. I'll close and submit another PR that will fix the current issue in develop.