GlobalFishingWatch / anchorages_pipeline

Python pipeline for anchorages
Apache License 2.0
6 stars 3 forks source link

Port Events Min Points Bug #40

Closed bitsofbits closed 3 years ago

bitsofbits commented 5 years ago

See this slack thread: https://globalfishingwatch.slack.com/archives/C67TJ42BZ/p1548340848001200

In particular:

I think I’ve found the underlying problem. `min_required_positions` used here https://github.com/GlobalFishingWatch/anchorages_pipeline/blob/master/pipe_anchorages/port_events_pipeline.py#L62 is supposed to be `min_port_events_positions`. Those values are 200 and 2 respectively. What that means is that currently and day with less than 200 positions gets dropped from the output of port events. In this case, the vessel in question has less than 200 points on the 12th and 13th, so it’s exit gets dropped.