search

GlobalFishingWatch / forcedlabor

forcedlabor: forced labor model package
GNU General Public License v3.0
0 stars 0 forks source link

mean_performance output missing in ml_hyperpar #6

Closed gmcdonald-sfg closed 1 year ago

gmcdonald-sfg commented 1 year ago

When running 04_sensitivty_hyper.Rin the simplified_model branch of forced-labor-trustability, I get an error in line 122 when running this (see the related comment in the PR)

stats_plot <- stats_plot |>
  dplyr::select(mtry, min_n, regularization.factor, mean_performance)
 Error in `dplyr::select()`:
! Can't subset columns that don't exist.
✖ Column `mean_performance` doesn't exist.

It looks like in the current version of forcedlabor::ml_hyperpar, the best_hyperparameters output does not currently include the column for mean_performance. Should we add this back in?

gmcdonald-sfg commented 1 year ago

This was fixed by @rociojoo here