search

GlobalFishingWatch / gfwr

R package for accessing data from Global Fishing Watch APIs
https://globalfishingwatch.github.io/gfwr/
Apache License 2.0
58 stars 7 forks source link

Correct `parse_response_error()` #135

Closed AndreaSanchezTapia closed 2 months ago

AndreaSanchezTapia commented 4 months ago

The error handling function (parse_response_error(), formerly gist_error_body()) should always include the response status code in the error message it returns and check the content-type header of the response. Only attempt to parse the json body if the content type is application/json, or *+json.

AndreaSanchezTapia commented 2 months ago

Closing this one for now. Adressed by commenting all instances of this function. May reopen in the future.