search

GlobalFishingWatch / gfwr

R package for accessing data from Global Fishing Watch APIs
https://globalfishingwatch.github.io/gfwr/
Apache License 2.0
58 stars 7 forks source link

adding query and where to get_vessel_info() #140

Closed AndreaSanchezTapia closed 3 months ago

AndreaSanchezTapia commented 3 months ago

and error messages when NULL or mis-specified. This is for user-friendliness.

natemiller commented 3 months ago

@AndreaSanchezTapia Can a user input both query and where? Right now it seems like if they did the result would be a query as that test comes first. Is that what we want?

AndreaSanchezTapia commented 3 months ago

According to the documentation it's one or the other but we can ask. In that case I should add a test for when none is null.

AndreaSanchezTapia commented 3 months ago

@natemiller confirming no, it's one or the other, if you send both it's 422 unprocessable. I'll correct that. I'll add the test.